Repository navigation
Conversation
7289e7f to
b6a6b9e
Compare
|
@jona42-ui do you still plan to work on some tests? Thank you! |
5cca2c4 to
aca20dd
Compare
…llback The nullish coalescing operator (??) only triggers on null or undefined, not on empty strings. When the URL path is '/', pathname.slice(1) returns '' which is falsy but not null/undefined, causing mqv:filter and mqv:topic to be silently ignored. Fixes eclipse-thingweb#1508 Signed-off-by: jona42-ui <jonathanthembo123@gmail.com>
Verify that subscribeResource uses mqv:filter when the form href has no path (eclipse-thingweb#1508), and that it rejects when neither a path nor mqv:filter is provided. Signed-off-by: jona42-ui <jonathanthembo123@gmail.com>
…sing filter" This reverts commit aca20dd.
5da0bb9 to
a6ee53d
Compare
|
Hi @jona42-ui bad luck that I had some unstage work done this weekend. I reverted your commit as I introduced a separate file to test the URI logic exactly. Thank you anyway for your time and your contribution to node-wot! Really appreciate it. @danielpeintner let me know if you are okay to merge it. note: I reverted your commit so that it still visibile in the history, if some other maitainers prefer your version of the test we can drop my revert. |
aah no worries @relu91 . thank you for the good work welldone. |
use the logical OR operator (||) instead of nullish coalescing (??)
Fixes #1508